Fix documentation typo, inin → in
#842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
reviewed
Jan 23, 2024
lib/irb.rb
Outdated
| @@ -207,7 +207,7 @@ | |||
| # in file <tt>~/.irb_history</tt> | |||
| # (or, if a {configuration file}[rdoc-ref:IRB@Configuration+File] | |||
| # is found, in file +.irb_history+ | |||
| # inin the same directory as that file). | |||
| # in the same directory as that file). | |||
There was a problem hiding this comment.
In addition to the typo, the entire sentence reads a bit weird 🤔 Would you mind improving it altogether?
There was a problem hiding this comment.
Pushed a larger change.
elebow
force-pushed
the
fix-doc-typo-inin
branch
from
cacfa0e to
a1632b2
Compare
| # By default, \IRB stores a history of up to 1000 input commands in a | ||
| # file named <tt>.irb_history</tt>. The history file will be in the same directory | ||
| # as the {configuration file}[rdoc-ref:IRB@Configuration+File] if one is found, or | ||
| # in <tt>~/</tt> otherwise. |
There was a problem hiding this comment.
I like that it added more clarity on the behaviour, too! 🚀
There was a problem hiding this comment.
PS: I think this is good to go!
st0012
approved these changes
Jan 25, 2024
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.